Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/779#discussion_r142412429
  
    --- Diff: 
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
 ---
    @@ -35,7 +36,7 @@
       @ResponseBody
       ResponseEntity<?> handleControllerException(HttpServletRequest request, 
Throwable ex) {
         HttpStatus status = getStatus(request);
    -    return new ResponseEntity<>(new RestError(status.value(), 
ex.getMessage(), getFullMessage(ex)), status);
    +    return new ResponseEntity<>(new RestError(status.value(), 
ex.getMessage(), ExceptionUtils.getStackTrace(ex)), status);
    --- End diff --
    
    My preference would be -> root cause only.  Stack trace if profile is not 
production.  Stack trace to log.
    
    I will not hold this back for that, but if this gets audited, that is what 
is going to have to be done later.


---

Reply via email to