GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/786
METRON-1231: Separate Sensor name and topic in the Management UI
## Contributor Comments
This PR separates sensor name and sensor Kafka topic in both the REST app
as well as the Management UI. The SensorParserConfigController
[POST](http://node1:8082/swagger-ui.html#!/sensor-parser-config-controller/saveUsingPOST_5)
endpoint now accepts a `name` path variable that represents the sensor name
and the
[getAll](http://node1:8082/swagger-ui.html#!/sensor-parser-config-controller/findAllUsingGET_1)
endpoint now returns a map with the sensor name as the key and config as the
value (was just a list before).
This has been tested in full dev. To verify, log in to the Management UI
and create or edit a sensor. There should now be separate inputs for sensor
name and Kafka topic. Editing one should not affect the other and vice-versa.
The Kafka topic field should function the same as it did before. There was a
significant refactor required so the Management UI should be tested to ensure
all the features still work and no regressions were introduced.
The REST endpoints should also function normally and include the new
behavior mentioned above.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1231
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/786.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #786
----
commit c2013b0e390eb776aff6f32257c0e371fa562025
Author: merrimanr <merrim...@gmail.com>
Date: 2017-10-04T18:58:49Z
initial commit
commit 7f027ade0af32f381b48d0144363b76dfcc48644
Author: merrimanr <merrim...@gmail.com>
Date: 2017-10-04T19:05:14Z
Merge remote-tracking branch 'mirror/master' into METRON-1231
# Conflicts:
#
metron-interface/metron-config/src/app/sensors/sensor-parser-config/sensor-parser-config.component.ts
commit 073c3def971304e9e07dda2dacde18396bdebecb
Author: merrimanr <merrim...@gmail.com>
Date: 2017-10-04T19:13:23Z
resolved merge conflict
----
---
