Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/813#discussion_r146276684
  
    --- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/StormControllerIntegrationTest.java
 ---
    @@ -187,9 +187,9 @@ public void test() throws Exception {
         sensorParserConfig.setSensorTopic("broTest");
         sensorParserConfigService.save(sensorParserConfig);
         {
    -      final Map<String, Object> expectedGlobalConfig = globalConfig;
    +      final SensorParserConfig expectedSensorParserConfig = 
sensorParserConfig;
           //we must wait for the config to find its way into the config.
    -      TestUtils.assertEventually(() -> 
Assert.assertEquals(expectedGlobalConfig, globalConfigService.get()));
    +      TestUtils.assertEventually(() -> 
Assert.assertEquals(expectedSensorParserConfig, 
sensorParserConfigService.findOne("broTest")));
    --- End diff --
    
    oh crap, that's not even a legit assertion.  I'm embarassed now ;)


---

Reply via email to