[GitHub] metron pull request #801: METRON-1254: Conditionals as map keys do not funct...

[ottobackwards]

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/801#discussion_r147238667
  
    --- Diff: 
metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4
 ---
    @@ -249,6 +253,7 @@ identifier_operand :
       | NULL #NullConst
       | EXISTS LPAREN IDENTIFIER RPAREN #ExistsFunc
       | LPAREN conditional_expr RPAREN #condExpr_paren
    --- End diff --
    
    Why are we specifying the #func function?
    * We don't implement it
    * The name should be better


---