Github user jjmeyer0 commented on a diff in the pull request:

    https://github.com/apache/metron/pull/814#discussion_r147556836
  
    --- Diff: 
metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4
 ---
    @@ -272,4 +278,30 @@ lambda_variable:
       IDENTIFIER
       ;
     
    +match_expr :
    +  MATCH LBRACE match_clauses RBRACE #MatchClauses
    +  ;
    +
    +match_clauses :
    +  match_clause (COMMA match_clause)*
    +  ;
    +
    +match_clause :
    +  match_clause_check COLON  match_clause_action
    +  ;
    +
    +match_clause_action :
    +  match_clause_action_expr #MatchClauseAction
    +  ;
     
    +match_clause_action_expr :
    +  transformation_expr
    +  ;
    +
    +match_clause_check :
    --- End diff --
    
    Is this extra expression needed? Could we get rid of it? Instead of this 
just have what's below?
    
    ```
    match_clause_action :
      transformation_expr #MatchClauseAction
      ;
    
    match_clause_check :
      logical_expr #MatchClauseCheckExpr
      ;
    ```


---

Reply via email to