Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/803#discussion_r147853082
  
    --- Diff: 
metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.po.ts ---
    @@ -159,4 +159,34 @@ export class TreeViewPage {
           return column.getText();
         });
       }
    +
    +  clickOnMergeAlerts(groupName: string) {
    +    return element(by.css('[data-name="' + groupName + '"] 
.fa-link')).click();
    +  }
    +
    +  getConfirmationText() {
    +    browser.sleep(1000);
    +    let dialogElement = element(by.css('.metron-dialog .modal-header 
.close'));
    +    return waitForElementVisibility(dialogElement).then(() =>  
element(by.css('.metron-dialog .modal-body')).getText());
    +  }
    +
    +  clickNoForConfirmation() {
    +    browser.sleep(1000);
    +    let dialogElement = element(by.css('.metron-dialog .modal-header 
.close'));
    +    let maskElement = element(by.css('.modal-backdrop.fade'));
    +    waitForElementVisibility(dialogElement).then(() => 
element(by.css('.metron-dialog')).element(by.buttonText('Cancel')).click())
    +    .then(() => waitForElementInVisibility(maskElement));
    +  }
    +
    +  clickYesForConfirmation() {
    +    browser.sleep(1000);
    --- End diff --
    
    Is this sleep statement absolutely necessary?


---

Reply via email to