Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/827#discussion_r149177390 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java --- @@ -236,17 +236,14 @@ public void test() throws Exception { .andExpect(jsonPath("$.groupResults[0].groupResults[0].score").value(50)); this.mockMvc.perform(post(searchUrl + "/column/metadata").with(httpBasic(user, password)).with(csrf()).contentType(MediaType.parseMediaType("application/json;charset=UTF-8")).content("[\"bro\",\"snort\"]")) - .andExpect(status().isOk()) - .andExpect(content().contentType(MediaType.parseMediaType("application/json;charset=UTF-8"))) - .andExpect(jsonPath("$.*", hasSize(2))) - .andExpect(jsonPath("$.bro.common_string_field").value("string")) - .andExpect(jsonPath("$.bro.common_integer_field").value("integer")) - .andExpect(jsonPath("$.bro.bro_field").value("boolean")) - .andExpect(jsonPath("$.bro.duplicate_field").value("date")) - .andExpect(jsonPath("$.snort.common_string_field").value("string")) - .andExpect(jsonPath("$.snort.common_integer_field").value("integer")) - .andExpect(jsonPath("$.snort.snort_field").value("double")) - .andExpect(jsonPath("$.snort.duplicate_field").value("long")); + .andExpect(status().isOk()) --- End diff -- Yes the `SearchControllerIntegrationTest` does not actually exercise the ElasticsearchDAO and I find this confusing as well. Really all the `SearchControllerIntegrationTest` tests is that serialization/deserialization happens correctly (which is still valuable).
---