Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/826#discussion_r149420627
  
    --- Diff: 
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/KafkaConfig.java
 ---
    @@ -108,6 +108,9 @@ public ZkUtils zkUtils() {
         producerConfig.put("key.serializer", 
"org.apache.kafka.common.serialization.StringSerializer");
         producerConfig.put("value.serializer", 
"org.apache.kafka.common.serialization.StringSerializer");
         producerConfig.put("request.required.acks", 1);
    +    if 
(environment.getProperty(MetronRestConstants.KERBEROS_ENABLED_SPRING_PROPERTY, 
Boolean.class, false)) {
    +      producerConfig.put("security.protocol", "SASL_PLAINTEXT");
    --- End diff --
    
    Shouldn't we pull this from the `KAFKA_SECURITY_PROTOCOL` environment 
variable?  Looks like it's being set in 
`metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/metron.j2`


---

Reply via email to