Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/824#discussion_r149422318
  
    --- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/Constants.java
 ---
    @@ -29,6 +29,7 @@
       public static final String ZOOKEEPER_TOPOLOGY_ROOT = ZOOKEEPER_ROOT + 
"/topology";
       public static final long DEFAULT_CONFIGURED_BOLT_TIMEOUT = 5000;
       public static final String SENSOR_TYPE = "source.type";
    +  public static final String SOURCE_TYPE = SENSOR_TYPE.replace('.', ':');
    --- End diff --
    
    This doesn't feel like it should exist in Constants.java as it's very ES 
specific (solr would not work this way, for instance).  Maybe we could have an 
ElasticsearchConstants or just move this to a constant in the ESDao?


---

Reply via email to