Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/843#discussion_r151801296
  
    --- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java
 ---
    @@ -132,6 +132,30 @@ public void testDefaultQuery() throws Exception {
         sensorIndexingConfigService.delete("bro");
       }
     
    +  @Test
    +  public void testDefaultColumnMetadata() throws Exception {
    --- End diff --
    
    Let me explain better.  I assume this is testing that the set of default 
indices are used.  That's just not clear to me how we are verifying that here.
    
    Whereas, in your other test case 
`getColumnMetadataShouldProperlyGetDefaultIndices` that makes it very clear to 
me what you are testing. :)


---

Reply via email to