Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
+1
I'd like to see sign-off from at least one other committer (if not more)
before this gets merged.
I previously outlined the manual functional testing that I performed. All
the core functionality is there. We also have sufficient test coverage for the
functionality that was added.
I have been able to get the e2e tests to run good enough (IMO) to move
forward with the PR. Based on the experimentation that I describe below, I
believe that the test failures are due to the tests and test infrastructure and
not the core functionality in the PR.
The intermittent failures are a pre-existing condition to this PR. This
makes me comfortable enough to merge this PR and then follow-on with test
fixes. @iraghumitra mentioned that he is currently working on improving the
tests and will open a separate PR.
1. I used Brew to install the following versions of Node/NPM.
```
$ node --version
v8.9.1
$ npm --version
5.5.1
```
2. Before running the tests, truncate the `metron_update` table. The tests
cannot currently clear out old test data stored in HBase.
3. Enabling/disabling sets of tests in
`metron-interface/metron-alerts/protractor.conf.js` also allowed me to see that
all the tests can pass on an intermittent basis. It seems that earlier test
failures may cause later tests to fail unnecessarily.
4. Run the e2e tests using the following steps.
```
cd metron-interface/metron-alerts
npm install
./node_modules/.bin/webdriver-manager update
./node_modules/.bin/protractor
```
Thanks for working through this with me @iraghumitra.
---
