Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/851#discussion_r154802693
  
    --- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
 ---
    @@ -343,25 +343,42 @@ public static void uploadConfigsToZookeeper(String 
rootFilePath, CuratorFramewor
        * @param type config type to upload configs for
        * @param configName specific config under the specified config type
        */
    -  public static void uploadConfigsToZookeeper(String rootFilePath, 
CuratorFramework client,
    -      ConfigurationType type, Optional<String> configName) throws 
Exception {
    +  public static void uploadConfigsToZookeeper(
    +          String rootFilePath,
    --- End diff --
    
    No.  I guess I miss read the ambition of this pr, given the meta-pr and all 
;)


---

Reply via email to