Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/863#discussion_r156372868
  
    --- Diff: 
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java
 ---
    @@ -229,17 +239,30 @@ public void execute(Tuple tuple) {
           LOG.trace("Writing enrichment message: {}", message);
           WriterConfiguration writerConfiguration = 
configurationTransformation.apply(
                   new IndexingWriterConfiguration(bulkMessageWriter.getName(), 
getConfigurations()));
    -      if(writerConfiguration.isDefault(sensorType)) {
    -        //want to warn, but not fail the tuple
    -        collector.reportError(new Exception("WARNING: Default and (likely) 
unoptimized writer config used for " + bulkMessageWriter.getName() + " writer 
and sensor " + sensorType));
    +      if(sensorType == null) {
    --- End diff --
    
    Maybe we should validate all the required fields?


---

Reply via email to