Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/867#discussion_r156792461
--- Diff: metron-analytics/metron-statistics/README.md ---
@@ -53,6 +53,32 @@ functions can be used from everywhere where Stellar is
used.
* bounds - A list of value bounds (excluding min and max) in sorted
order.
* Returns: Which bin N the value falls in such that bound(N-1) < value <=
bound(N). No min and max bounds are provided, so values smaller than the 0'th
bound go in the 0'th bin, and values greater than the last bound go in the M'th
bin.
+### Sampling Functions
+
+#### `SAMPLE_ADD`
+* Description: Add a value or collection of values to a sampler.
+* Input:
--- End diff --
Couldn't this be simplified to
```java
if(ret == null ) {
if(obj != null) {
throw new IllegalStateException(argName + "argument(" + obj
+ " is expected to be an " +
expectedClazz.getName()
+ ", but was " + obj
);
}
}
return Optional.ofNullable(ret);
```
---
