I would expect so. Honestly, it's probably more just getting PRs out on it, and adjusting if it ends up causing problems. Given that we just did a release, this is probably the best time to at least do a couple modules, see if any problems are caused, and clean it up afterwards.
On Wed, Jan 17, 2018 at 12:20 PM, Otto Fowler <ottobackwa...@gmail.com> wrote: > Thanks, > I have check style up and integrated, and I have been running it on *new* > files etc. > But now when I work in existing, I obviously see the issues. > > I *think* in the end module by module is the only feasible way is it not? > > > On January 17, 2018 at 12:15:33, Justin Leet (justinjl...@gmail.com) > wrote: > > It exists, we have a style that can be imported and setup in IntelliJ with > the Checkstyle plugin > > Reformatting can also be done in IntelliJ (which will help a lot, but not > all issues). This can be done on a file mask basis (e.g. just do "*.java" > files to avoid reformatting other things), and could be done module wide > or > project wide or whatever. I would turn off autoformatting of Javadocs in > IntelliJ (because a lot of the Apache license headers are Javadocs instead > of comments). Other than that, I don't think there are any other problems. > > The main problem is more taking the time to do it, avoiding issues with > existing PRs, and making it manageable to review and take care of. Do we > do it module by module (keeping in mind we have a whole lot)? Things like > that. I'm happy to help out, but I just really haven't put in the effort > to > get things moving forward. > > > On Wed, Jan 17, 2018 at 9:12 AM, Otto Fowler <ottobackwa...@gmail.com> > wrote: > > > Where are we with the check style integration? How are we handling check > > style in existing modules? > > I seem to remember talk of a script or something to reformat? > > > > It would be nice to get some of the warnings out of the builds, how > should > > we go about it? > > > > ottO > > > >
