GitHub user anandsubbu reopened a pull request:

    https://github.com/apache/metron/pull/888

    METRON-1389: Zeppelin notebook import does not work with Ambari 2.6

    ## Contributor Comments
    In recent versions of Ambari, [Shiro 
Authentication](https://zeppelin.apache.org/docs/0.6.0/security/shiroauthentication.html)
 is enabled on the Zeppelin server, which requires a user/password 
authentication in order to interact with Zeppelin REST API. 
    
    This pull request adds support for using the Shiro auth credentials and 
thus being able to import Zeppelin notebooks. Backward compatibility with 
non-authenticated Zeppelin has been maintained as well so that the full dev 
platform (which runs on an older Ambari version) is not broken.
    
    **Steps to test the PR**
    * In Ambari UI, go to Services -> Metron -> 'Service Actions' dropdown -> 
'Zeppelin Notebook Import'
    * Validate that the Metron notebooks are imported by launching the Zeppelin 
UI (Service -> Zeppelin Notebook -> 'Quick Links' dropdown -> Zeppelin UI)
    
    **Testing Done**
    * Ran the changes against Ambari ver 2.6.0.0 (which uses Shiro 
authentication) and verified that notebooks are imported properly
    * Ran the changes against Ambari ver 2.4.2.0 (which does not uses Shiro 
authentication) and verified that notebooks are imported properly
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anandsubbu/incubator-metron METRON-1389

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/888.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #888
    
----
commit e767022e6c87922f7a0c3ca143b7482548a0908c
Author: Anand Subramanian <asubramanian@...>
Date:   2018-01-05T06:10:04Z

    Add Shiro authentication support

commit b8780df0a0f1231a18597302302a3bd247b7dfd6
Author: Anand Subramanian <asubramanian@...>
Date:   2018-01-16T11:52:02Z

    Get admin user creds from Zeppelin shiro config in Ambari

commit 3a799da66ad1c9568f5fcb85cdc8ea8de8c9872a
Author: Anand Subramanian <asubramanian@...>
Date:   2018-01-22T09:16:19Z

    Feedback from Nick - refactor auth check into a separate method

----


---

Reply via email to