GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/929
METRON-1448: Update SolrWriter to conform to new collection strategy
## Contributor Comments
Currently the SolrWriter presumes a single collection to be written to.
The new collection strategy for Solr implies a collection per sensor. Also,
there are a few rough edges in the writer which could stand smoothing:
* By default, we use solr's implicit commit mechanism, rather than
committing at the batch granularity. This may result in lost data on worker
failure.
* We do not use the the batch add api, but rather message-by-message add
Testing plan pending.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron SOLR_writer_mod
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/929.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #929
----
commit 6bb30af9d2005414e3ee44c0bdb0ea14540ce13c
Author: cstella <cestella@...>
Date: 2018-02-01T21:33:56Z
METRON-1441: Create complementary Solr schemas for the main sensors
commit f4ff0c401eff23d9c1b2ca3b264bd9b0d4e8f381
Author: cstella <cestella@...>
Date: 2018-02-01T21:47:12Z
Updating dao
commit 7e2ecb0f2f55ea16529128fec14920bc2a546b07
Author: cstella <cestella@...>
Date: 2018-02-02T21:43:38Z
Migrated data to files, renamed test and added yaf and error.
commit 2aacd202ff1a2ebcbeb30300b30d080391cfe1cf
Author: cstella <cestella@...>
Date: 2018-02-02T21:45:08Z
Merge branch 'feature/METRON-1416-upgrade-solr' into SOLR_METRON-1441
commit 2e32e7ea4ef8cace764394c1dec693d8385a6b9a
Author: cstella <cestella@...>
Date: 2018-02-02T21:50:06Z
Added to readme.
commit e2901d4bd4b9787f668c2dccd2e4f8aa53a926d7
Author: cstella <cestella@...>
Date: 2018-02-05T14:39:31Z
Updating error to have a guid and removed docValues=true for bytes type.
commit 3c4319ec4581fdb259a697b548a267225316874a
Author: cstella <cestella@...>
Date: 2018-02-05T16:52:17Z
Missed spec file additions
commit 43e5ad2d4fb26ac8d6c4c623f427d6358b0c85fa
Author: cstella <cestella@...>
Date: 2018-02-05T21:53:23Z
Updated schema to include guid, which I missed earlier
commit 261c28b1b594de8b1d7a1357e54e2367c32d0652
Author: cstella <cestella@...>
Date: 2018-02-06T14:33:32Z
Blah, forgot guid field
commit 34e67cbb897938fd804286ecfcb5861e724c5886
Author: cstella <cestella@...>
Date: 2018-02-06T17:33:52Z
Added context and grouping for schemata
commit 62a2eb28c8410ad08529eec74bdba0958e71f1f8
Author: cstella <cestella@...>
Date: 2018-02-06T23:03:54Z
Updating solrwriter
commit bfbd65f3d18af14544673262d99f2c0840447009
Author: cstella <cestella@...>
Date: 2018-02-06T23:20:54Z
Updating config.
commit 3faace9509903f5436dd8b9242bc3b2fc2343af0
Author: cstella <cestella@...>
Date: 2018-02-07T16:32:56Z
Merge branch 'feature/METRON-1416-upgrade-solr' into SOLR_writer_mod
----
---
