Github user dcode commented on the issue:

    https://github.com/apache/metron-bro-plugin-kafka/pull/6
  
    Oh I wasn't trying to throw accusations. I actually contributed that code
    to the bro plugins repo and a couple other forks. I can remove the default
    on behavior. I this patch in RockNSM and haven't experienced an Error loop.
    
    On Feb 24, 2018 13:14, "JonZeolla" <notificati...@github.com> wrote:
    
    Thanks @dcode <https://github.com/dcode> I'll need to review this more
    specifically but I don't recall using any of your contributions for my
    other work. I modeled it after other plugins in the old bro-plugins repo.
    
    We have also discussed the default on vs not before and I think we settled
    on default off. However, even if you wanted to do something default on you
    should exclude reporter.log otherwise you can get in an infinite loop with
    errors.
    
    —
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on GitHub
    
<https://github.com/apache/metron-bro-plugin-kafka/pull/6#issuecomment-368252107>,
    or mute the thread
    
<https://github.com/notifications/unsubscribe-auth/AAKeNrJj33_LfZgvi87uTA6qmEJZjejaks5tYF97gaJpZM4SR7Xg>
    .



---

Reply via email to