Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/940#discussion_r172377136
  
    --- Diff: 
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/parallel/EnrichmentStrategies.java
 ---
    @@ -0,0 +1,79 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.enrichment.parallel;
    +
    +import org.apache.metron.common.Constants;
    +import 
org.apache.metron.common.configuration.enrichment.SensorEnrichmentConfig;
    +import 
org.apache.metron.common.configuration.enrichment.handler.ConfigHandler;
    +import org.apache.metron.enrichment.bolt.CacheKey;
    +import org.json.simple.JSONObject;
    +import org.slf4j.Logger;
    +
    +import java.util.Map;
    +import java.util.concurrent.Executor;
    +
    +public enum EnrichmentStrategies implements Strategy {
    --- End diff --
    
    I might be answering a question that you're not asking, but this bit of 
awkwardness arises because we have merged the concepts of threat intel and 
enrichment, which differ really only in post-processing.  The approach 
presented here, in contrast to the inheritance-based approach in the bolts, 
allows for an abstraction through composition whereby we localize all the 
interactions with the sensor enrichment config in a strategy rather than bind 
the abstraction to Storm, our distributed processing engine.  That is the 
rationale behind this approach at least.


---

Reply via email to