Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/958#discussion_r173933259
  
    --- Diff: 
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/sampler/UnbiasedSampler.java
 ---
    @@ -0,0 +1,28 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.performance.sampler;
    +
    +import java.util.Random;
    +
    +public class UnbiasedSampler implements Sampler {
    +
    +  @Override
    +  public int sample(Random rng, int limit) {
    +    return rng.nextInt(limit);
    --- End diff --
    
    If the templates file is empty, there will be no bounds here, and this will 
start puking exceptions out.


---

Reply via email to