Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/958#discussion_r174181759 --- Diff: metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/SendToKafka.java --- @@ -0,0 +1,107 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.metron.performance.load; + +import org.apache.kafka.clients.producer.KafkaProducer; +import org.apache.kafka.clients.producer.ProducerRecord; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.TimerTask; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Future; +import java.util.concurrent.atomic.AtomicLong; +import java.util.function.Supplier; + +public class SendToKafka extends TimerTask { --- End diff -- well, I mean, I suppose it could be, but I didn't see value in it since all of our inputs currently are strings and the message generator exclusively generates strings, not other messages. It'd be a more serious refactoring to genericize this to make the message generator pluggable. Also, for utility code, I think I'd rather avoid prematurely generalizing it. Let me know what you think.
---