I don't think it should hold up the release. It's *extremely* rare, even though it's come up twice. I wanted to be preemptive about bringing up the intermittent failure list because we agreed as a community on this being a regular release cycle review step. I think all those voting on the release should have a full awareness of issues seen and vote accordingly as to whether we should move forward or address a problem first. Having reviewed the test-failures list, I'm in favor of moving forward with the release.
On Wed, Apr 17, 2019 at 9:29 AM Nick Allen <n...@nickallen.org> wrote: > Oh, and that failure from 21 days ago was caused by a downstream issue > brought in by PR #1364, that we then later reverted [1]. So at least that > particular issue has been identified and addressed and should no longer > impacts builds. > > --- > [1] > > https://github.com/apache/metron/commit/cad679a5948ce0ee9866e61bbf75b1f5f255682c > > On Wed, Apr 17, 2019 at 11:25 AM Nick Allen <n...@nickallen.org> wrote: > > > Are you suggesting the release should wait on this? Personally, I don't > > feel that we have any *persistently intermittent* test failures that > would > > block a release. The last build failure on master I see was from 21 days > > ago. > > > > Otherwise, I'd really like to kick off the next release. > > > > On Tue, Apr 16, 2019 at 11:25 AM Michael Miklavcic < > > michael.miklav...@gmail.com> wrote: > > > >> FYI, I just saw one of our reported intermittent test failures pop up > >> again > >> today - https://issues.apache.org/jira/browse/METRON-1814 > >> > >> On Mon, Apr 15, 2019 at 2:22 PM Michael Miklavcic < > >> michael.miklav...@gmail.com> wrote: > >> > >> > I want to thread the needle on this. I just reviewed a PR from Ryan > that > >> > addresses this and gave it a +1. > >> > https://github.com/apache/metron/pull/1381 > >> > > >> > I think Jon Zeolla and Justin Leet should have an opportunity to chime > >> in > >> > as they also had commented about this request in the original PR. > >> > > >> > One other thing to note - we had agreed last time around to do a scan > >> over > >> > any intermittent test failures encountered and assess whether or not > >> they > >> > were still valid. I'd like to ask the community to take a look and > >> comment > >> > on whether any of these has appeared for them. From what I can tell > >> after > >> > having looked them over, it looks like random Travis issues. I haven't > >> > experienced any of these locally in quite some time. > >> > > >> > https://issues.apache.org/jira/browse/METRON-2077?jql=project%20%3D%20METRON%20AND%20resolution%20%3D%20Unresolved%20AND%20labels%20%3D%20test-failure%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC > >> > > >> > Best, > >> > Mike > >> > > >> > On Fri, Apr 5, 2019 at 11:50 AM Ryan Merriman <merrim...@gmail.com> > >> wrote: > >> > > >> >> Jon is correct. I am actively working on this and hope to have it > >> >> completed soon. I realize it will hold up the release so it's a > >> priority > >> >> for me. > >> >> > >> >> On Sat, Mar 30, 2019 at 6:09 PM zeo...@gmail.com <zeo...@gmail.com> > >> >> wrote: > >> >> > >> >> > Isn't the documentation already in progress? > >> >> > > >> >> > https://github.com/apache/metron/pull/1330#issuecomment-466453372 > >> >> > > >> >> > If not I would still consider it important to complete prior to a > >> >> release > >> >> > and I agree with Justin's comments in > >> >> > > >> >> > > >> >> > > >> >> > >> > https://lists.apache.org/thread.html/50b89b919bd8bef3f7fcdef167cbd7e489fa74a1e2da3e4fddb08b13@ > >> >> > <dev.metron.apache.org> > >> >> > > >> >> > Jon Zeolla > >> >> > > >> >> > On Thu, Mar 28, 2019, 2:16 PM Michael Miklavcic < > >> >> > michael.miklav...@gmail.com> > >> >> > wrote: > >> >> > > >> >> > > Jon and Ryan - this was a convo/negotiation between you two at > the > >> >> time. > >> >> > > Any thoughts? > >> >> > > > >> >> > > On Thu, Mar 28, 2019 at 9:08 AM Nick Allen <n...@nickallen.org> > >> >> wrote: > >> >> > > > >> >> > > > Is anyone volunteering to take this on? Would be nice to get a > >> >> release > >> >> > > > out. > >> >> > > > > >> >> > > > On Thu, Mar 14, 2019, 4:53 PM zeo...@gmail.com < > zeo...@gmail.com > >> > > >> >> > wrote: > >> >> > > > > >> >> > > > > We should likely get METRON-2014 in, based on > >> >> > > > > > >> >> > > > > > >> >> > > > > >> >> > > > >> >> > > >> >> > >> > https://lists.apache.org/thread.html/13bd0ed5606ad4f3427f24a8e759d6bcb61ace76d4afcc9f48310a00@%3Cdev.metron.apache.org%3E > >> >> > > > > > >> >> > > > > On Thu, Mar 14, 2019 at 4:24 PM Michael Miklavcic < > >> >> > > > > michael.miklav...@gmail.com> wrote: > >> >> > > > > > >> >> > > > > > Ticket is now done and merged. I'm also good on 0.7.1. > >> >> > > > > > > >> >> > > > > > On Thu, Mar 14, 2019 at 2:18 PM Justin Leet < > >> >> justinjl...@gmail.com > >> >> > > > >> >> > > > > wrote: > >> >> > > > > > > >> >> > > > > > > I'm in favor doing a release, pending the ticket Mike > >> pointed > >> >> out > >> >> > > > (and > >> >> > > > > > > anything else someone comes up with). > >> >> > > > > > > > >> >> > > > > > > To the best of my knowledge, I think 0.7.1 is sufficient, > >> but > >> >> if > >> >> > > > > someone > >> >> > > > > > > comes up with something, it's not hard to pivot. > >> >> > > > > > > > >> >> > > > > > > On Wed, Mar 13, 2019, 13:08 Michael Miklavcic < > >> >> > > > > > michael.miklav...@gmail.com > >> >> > > > > > > > > >> >> > > > > > > wrote: > >> >> > > > > > > > >> >> > > > > > > > I'd like to see this fixed for the next release. > >> >> > > > > > > > https://issues.apache.org/jira/browse/METRON-2036. > Even > >> >> though > >> >> > > > it's > >> >> > > > > a > >> >> > > > > > > > non-prod issue, this is a core part of our > >> >> > > > infrastructure/development > >> >> > > > > > > > lifecycle that is currently broken and fits with our > >> >> previous > >> >> > > > > > agreements > >> >> > > > > > > of > >> >> > > > > > > > holding a release until all intermittent test failures > >> are > >> >> > > > addressed. > >> >> > > > > > > > > >> >> > > > > > > > On Wed, Mar 13, 2019 at 11:33 AM Nick Allen < > >> >> > n...@nickallen.org> > >> >> > > > > > wrote: > >> >> > > > > > > > > >> >> > > > > > > > > I would like to open a discussion in regards to the > >> next > >> >> > > release. > >> >> > > > > Our > >> >> > > > > > > > last > >> >> > > > > > > > > 0.7.0 release was on Dec 11th. > >> >> > > > > > > > > > >> >> > > > > > > > > I believe we have a significant number of bug fixes > and > >> >> > > > performance > >> >> > > > > > > > > improvements that would make a worthy point release; > >> >> 0.7.1. > >> >> > > > > > Although, > >> >> > > > > > > we > >> >> > > > > > > > > should review the change log and see if there are any > >> >> > breaking > >> >> > > > > > changes > >> >> > > > > > > > that > >> >> > > > > > > > > would require a bump to the minor version. > >> >> > > > > > > > > > >> >> > > > > > > > > Thoughts? > >> >> > > > > > > > > > >> >> > > > > > > > > $ git log --format=%B > >> >> > tags/apache-metron_0.7.0-release..HEAD | > >> >> > > > > grep > >> >> > > > > > > > > METRON- > >> >> > > > > > > > > Merge remote-tracking branch 'apache/master' into > >> >> METRON-2035 > >> >> > > > > > > > > METRON-2035 Allow User to Configure Role Names for > >> Access > >> >> > > Control > >> >> > > > > > > > > METRON-2030 > SensorParserGroupControllerIntegrationTest > >> >> > > > intermittent > >> >> > > > > > > > errors > >> >> > > > > > > > > (merrimanr via mmiklavc) closes apache/metron#1352 > >> >> > > > > > > > > METRON-2031 [UI] Turning off initial search request > and > >> >> > polling > >> >> > > > by > >> >> > > > > > > > default > >> >> > > > > > > > > on Alerts UI (tiborm via mmiklavc) closes > >> >> apache/metron#1353 > >> >> > > > > > > > > METRON-2012 Unable to Execute Stellar Functions > Against > >> >> HBase > >> >> > > in > >> >> > > > > the > >> >> > > > > > > REPL > >> >> > > > > > > > > (nickwallen) closes apache/metron#1345 > >> >> > > > > > > > > METRON-1971 Short timeout value in Cypress may cause > >> build > >> >> > > > failures > >> >> > > > > > > > > (sardell) closes apache/metron#1323 > >> >> > > > > > > > > METRON-1940 Check if not and install Elastic search > >> >> > templates / > >> >> > > > > Solr > >> >> > > > > > > > > collections when indexing server is restarted > (MohanDV) > >> >> > closes > >> >> > > > > > > > > apache/metron#1305 > >> >> > > > > > > > > METRON-2019 Improve Metron REST Logging (merrimanr) > >> closes > >> >> > > > > > > > > apache/metron#1347 > >> >> > > > > > > > > METRON-2016 Parser aggregate groups should be > persisted > >> >> and > >> >> > > > > available > >> >> > > > > > > > > through REST (merrimanr) closes apache/metron#1346 > >> >> > > > > > > > > METRON-1987 Upgrade Alert UI to stable Bootstrap 4 > >> >> (sardell) > >> >> > > > closes > >> >> > > > > > > > > apache/metron#1336 > >> >> > > > > > > > > METRON-1968 Messages are lost when a parser produces > >> >> multiple > >> >> > > > > > messages > >> >> > > > > > > > and > >> >> > > > > > > > > batch size is greater than 1 (merrimanr) closes > >> >> > > > apache/metron#1330 > >> >> > > > > > > > > METRON-1778 Out-of-order timestamps may delay flush > in > >> >> Storm > >> >> > > > > Profiler > >> >> > > > > > > > > (nickwallen) closes apache/metron#1197 > >> >> > > > > > > > > METRON-1996 Solr search throws NPE for group search > if > >> the > >> >> > > group > >> >> > > > > > > > parameter > >> >> > > > > > > > > is null or empty (MohanDV via nickwallen) closes > >> >> > > > apache/metron#1333 > >> >> > > > > > > > > METRON-1944 Unable to Delete a Comment in Alerts UI > >> >> > (ruffle1986 > >> >> > > > via > >> >> > > > > > > > > sardell) closes apache/metron#1307 > >> >> > > > > > > > > METRON-2010 Unable to Build Metron Due to > Inaccessible > >> >> > > Repository > >> >> > > > > > > > > (nickwallen) closes apache/metron#1343 > >> >> > > > > > > > > METRON-1998 Only one sensor is flushed by tick tuple > >> >> > > (merrimanr) > >> >> > > > > > closes > >> >> > > > > > > > > apache/metron#1335 > >> >> > > > > > > > > METRON-2009 Address Javadoc checkstyle issues in > >> >> > metron-common > >> >> > > > > > > > (justinleet) > >> >> > > > > > > > > closes apache/metron#1342 > >> >> > > > > > > > > METRON-2005 Batch Writer writes 0-byte files to HDFS > on > >> >> > > rotation > >> >> > > > > > > > > (justinleet) closes apache/metron#1338 > >> >> > > > > > > > > METRON-2007 Management UI not loading grok statements > >> >> > correctly > >> >> > > > > > > > (merrimanr) > >> >> > > > > > > > > closes apache/metron#1340 > >> >> > > > > > > > > METRON-1986 Batch Profiler Fails to Resolve Stats > >> Stellar > >> >> > > > Functions > >> >> > > > > > > > > (nickwallen) closes apache/metron#1328 > >> >> > > > > > > > > METRON-1993 Stellar REST_GET should handle responses > >> when > >> >> > > content > >> >> > > > > > > length > >> >> > > > > > > > is > >> >> > > > > > > > > less than zero (merrimanr) closes apache/metron#1331 > >> >> > > > > > > > > METRON-1999 Adding validation against special > >> characters > >> >> to > >> >> > > > parser > >> >> > > > > > name > >> >> > > > > > > > > field (tiborm via sardell) closes apache/metron#1337 > >> >> > > > > > > > > METRON-1985 Improve Error Handling When Cannot > Connect > >> to > >> >> > HBase > >> >> > > > > > > > > (nickwallen) closes apache/metron#1327 > >> >> > > > > > > > > METRON-1974 Batch Profiler Should Handle Errant > >> Profiles > >> >> > Better > >> >> > > > > > > > > (nickwallen) closes apache/metron#1326 > >> >> > > > > > > > > METRON-1970 Add Metadata to Error Messages Generated > >> >> During > >> >> > > > Parsing > >> >> > > > > > > > > (nickwallen) closes apache/metron#1325 > >> >> > > > > > > > > METRON-1995 Arrow icon in date range selector moved > to > >> a > >> >> > wrong > >> >> > > > > > position > >> >> > > > > > > > > (ruffle1986 via sardell) closes apache/metron#1332 > >> >> > > > > > > > > METRON-1973 Upgrade Alert UI's > webpack-dev-server > >> to > >> >> > > 3.1.14 > >> >> > > > > > > (tiborm > >> >> > > > > > > > > via sardell) closes apache/metron#1324 > >> >> > > > > > > > > METRON-1948 Dropped messages from REGEX_SELECT parser > >> >> field > >> >> > > > > > > > transformation > >> >> > > > > > > > > are not acked in Storm (merrimanr) closes > >> >> apache/metron#1321 > >> >> > > > > > > > > METRON-1969 Adding Cypress documentation to Alert > >> >> UI's > >> >> > > > > README.md > >> >> > > > > > > > > (tiborm via sardell) closes apache/metron#1322 > >> >> > > > > > > > > METRON-1933 Improve build-utils helper scripts > >> (JonZeolla > >> >> via > >> >> > > > > > > > > ottobackwards) closes apache/metron#1297 > >> >> > > > > > > > > METRON-1962 Make entering JDBC details in REST config > >> to > >> >> be > >> >> > > > > optional > >> >> > > > > > > > > (anandsubbu) closes apache/metron#1318 > >> >> > > > > > > > > METRON-1929 Build GET_ASN Stellar function > (justinleet) > >> >> > closes > >> >> > > > > > > > > apache/metron#1299 > >> >> > > > > > > > > METRON-1956 prepare-commit does not run all the tests > >> it > >> >> > should > >> >> > > > > > > > > (ottobackwards) closes apache/metron#1315 > >> >> > > > > > > > > METRON-1965 Knox should work on a multi-node > >> installation > >> >> > > > > (merrimanr) > >> >> > > > > > > > > closes apache/metron#1320 > >> >> > > > > > > > > METRON-1939 Update version to 0.7.1 (justinleet via > >> >> > nickwallen) > >> >> > > > > > closes > >> >> > > > > > > > > apache/metron#1303 > >> >> > > > > > > > > METRON-685 Scores in Threat Triage should be a > Stellar > >> >> > > Statement > >> >> > > > > > > > > (nickwallen) closes apache/metron#1311 > >> >> > > > > > > > > METRON-1963 Remove left over integration test from > >> before > >> >> > > > > refactoring > >> >> > > > > > > > > (ottobackwards) closes apache/metron#1319 > >> >> > > > > > > > > METRON-1945 Metron MPack support for Knox SSO setup > >> >> > (merrimanr) > >> >> > > > > > closes > >> >> > > > > > > > > apache/metron#1308 > >> >> > > > > > > > > METRON-1878 Add Metron as a Knox service (merrimanr) > >> >> closes > >> >> > > > > > > > > apache/metron#1275 > >> >> > > > > > > > > METRON-1958 Optimize Cypress to use best practices > >> >> (sardell > >> >> > via > >> >> > > > > > > > merrimanr) > >> >> > > > > > > > > closes apache/metron#1317 > >> >> > > > > > > > > METRON-1957 5424 and 3164 parser configurations are > >> >> packaged > >> >> > in > >> >> > > > > wrong > >> >> > > > > > > > place > >> >> > > > > > > > > (ottobackwards) closes apache/metron#1316 > >> >> > > > > > > > > METRON-1955 Update metron SPEC file to include syslog > >> 3164 > >> >> > > parser > >> >> > > > > > > > > (anandsubbu via ottobackwards) closes > >> apache/metron#1314 > >> >> > > > > > > > > METRON-1893 Create a syslog 3164 parser > (ottobackwards) > >> >> > closes > >> >> > > > > > > > > apache/metron#1279 > >> >> > > > > > > > > METRON-1954 Commit Script Fails to Extract Usernames > >> with > >> >> > > > Numerals > >> >> > > > > > > > > (nickwallen) closes apache/metron#1313 > >> >> > > > > > > > > METRON-1953 Stellar REPL Fails on Start (nickwallen) > >> >> closes > >> >> > > > > > > > > apache/metron#1312 > >> >> > > > > > > > > METRON-1941 Alert Escalation Not Consistent in Alerts > >> UI > >> >> > > > > (ruffle1986 > >> >> > > > > > > via > >> >> > > > > > > > > nickwallen) closes apache/metron#1306 > >> >> > > > > > > > > METRON-1951: Add site-book generation to Travis build > >> >> > > (mmiklavc) > >> >> > > > > > closes > >> >> > > > > > > > > apache/metron#1310 > >> >> > > > > > > > > METRON-1934 Stellar should built without error prone > >> >> messages > >> >> > > > > > > > > (ottobackwards) closes apache/metron#1298 > >> >> > > > > > > > > METRON-1950: Site-book generation broken in master > >> >> (mmiklavc) > >> >> > > > > closes > >> >> > > > > > > > > apache/metron#1309 > >> >> > > > > > > > > METRON-1936 Cypress fails when trying to parse double > >> >> quotes > >> >> > > > > > (sardell) > >> >> > > > > > > > > closes apache/metron#1301 > >> >> > > > > > > > > METRON-1815: Separate metron-parsers into > >> >> > metron-parsers-common > >> >> > > > and > >> >> > > > > > > > > metron-parsers-storm (justinleet via mmiklavc) closes > >> >> > > > > > > apache/metron#1249 > >> >> > > > > > > > > METRON-1932 Update ES and Kibana to 5.6.14 > (JonZeolla) > >> >> closes > >> >> > > > > > > > > apache/metron#1296 > >> >> > > > > > > > > METRON-1938 Add Parser Debugger to READMEs > (nickwallen) > >> >> > closes > >> >> > > > > > > > > apache/metron#1304 > >> >> > > > > > > > > METRON-1925 Provide Verbose View of Profile Results > in > >> >> REPL > >> >> > > > > > > (nickwallen) > >> >> > > > > > > > > closes apache/metron#1292 > >> >> > > > > > > > > METRON-1795: General Purpose Regex Parser > (jadeepsinh2 > >> via > >> >> > > > > mmiklavc) > >> >> > > > > > > > closes > >> >> > > > > > > > > apache/metron#1245 > >> >> > > > > > > > > METRON-1892 Parser Debugger Should Load Config From > >> >> Zookeeper > >> >> > > > > > > > (nickwallen) > >> >> > > > > > > > > closes apache/metron#1278 > >> >> > > > > > > > > METRON-1937 Update public web site to point at 0.7.0 > >> new > >> >> > > release > >> >> > > > > > > > > (justinleet) closes apache/metron#1302 > >> >> > > > > > > > > METRON-1879 Allow Elasticsearch to Auto-Generate the > >> >> Document > >> >> > > ID > >> >> > > > > > > > > (nickwallen) closes apache/metron#1269 > >> >> > > > > > > > > METRON-1930 Update webpack-dev-server in Alerts UI > >> >> (sardell) > >> >> > > > closes > >> >> > > > > > > > > apache/metron#1294 > >> >> > > > > > > > > METRON-1849 Elasticsearch Index Write Functionality > >> >> Should be > >> >> > > > > Shared > >> >> > > > > > > > > (nickwallen) closes apache/metron#1254 > >> >> > > > > > > > > > >> >> > > > > > > > > >> >> > > > > > > > >> >> > > > > > > >> >> > > > > -- > >> >> > > > > > >> >> > > > > Jon Zeolla > >> >> > > > > > >> >> > > > > >> >> > > > >> >> > > >> >> > >> > > >> > > >
