Regarding contribution to the wiki - do we submit docs with pictures etc
when we need a bigger change.

Simple Comments:
* We need CLAs from folks who contribute.
* Need some detailed code style guidelines like
http://twitter.github.io/effectivescala/ or just point to scala/java
guidelines like this (also for python/go if we go that route for some
components)
* Guidelines for code review should also be posted. Every reviewer must
actually run the component and ensure unit tests are passed unless there
is a CI gate system for this.
* Features should not be accepted without tests.
* We should at least use a logging infra for the code.
* Ideally we need a CI gate for commits.
http://docs.openstack.org/infra/manual/developers.html …. We need a
precise process like this. Then it will be easier to grow the community.
* Naming convention should also be in the style guide.

Nits 
* Several lines with an extra dot after the itemized list

On 12/12/15, 7:35 AM, "James Sirota" <[email protected]> wrote:

>Hi Debo,
>
>You propose changes by responding to this thread and we’ll incorporate
>them into the document.
>
>Thanks,
>James
>
>
>
>On 12/12/15, 8:34 AM, "Debo Dutta (dedutta)" <[email protected]> wrote:
>
>>Ok can access but can’t edit … how do I get access?
>>
>>Looks like a gr8 start.
>>
>>On 12/12/15, 7:29 AM, "James Sirota" <[email protected]> wrote:
>>
>>>Ok try now 
>>>
>>>
>>>
>>>
>>>On 12/12/15, 8:26 AM, "Debo Dutta (dedutta)" <[email protected]> wrote:
>>>
>>>>can¹t access the wiki
>>>>
>>>>On 12/12/15, 7:11 AM, "James Sirota" <[email protected]> wrote:
>>>>
>>>>>I posted the proposed development guidelines for Metron that Andrew
>>>>>and
>>>>>the Rackspace team came up with.  Does anyone want to add/edit/remove
>>>>>anything in this wiki entry?  I¹d love to get this solidified by mid
>>>>>next
>>>>>week so we can call a vote on it.  We also need to fill out a couple
>>>>>of
>>>>>sections that don¹t have text in them.
>>>>>
>>>>>https://cwiki.apache.org/confluence/display/METRON/Development+Guideli
>>>>>ne
>>>>>s
>>>>>
>>>>>Thanks,
>>>>>James
>>>>
>>>>
>>

Reply via email to