Github user dlyle65535 commented on the pull request:
https://github.com/apache/incubator-metron/pull/62#issuecomment-202388095
Good catch! Thanks for the PR.
Lately, I'm a little reluctant to add ignore_errors without a fail block
immediately following. In this case, you could add a register: result to the
Upload grok patterns task followed by a fail task that fails if "File exists"
isn't in stdout. That would make sure it didn't ignore different types of
errors.
Since we're interacting with hdfs immediately prior to the file copy, I
think ignore_errors would be okay here, but if you had the time to add the fail
block, it would be preferred. It demonstrates the preferred pattern and gives
others a better example to follow.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
