+1 (binding) * checked LICENSE, NOTICE * verified signature * built from source * spun up vagrant instance * verified status with documented instructions
Note on build problems with rc5 - they were due to some of my local maven repo being owned by root - once I fixed that it worked fine. It does seem like we should be able to build from metron-streaming without rat failing. I haven't had a chance to look into what would need to be changed though. On Wed, Mar 30, 2016 at 3:26 PM, James Sirota <[email protected]> wrote: > Thanks, Taylor. Created Jira to address for next release: > https://issues.apache.org/jira/browse/METRON-90 > > > > > > > On 3/30/16, 12:19 PM, "P. Taylor Goetz" <[email protected]> wrote: > > >I checked: > > > >- DISCLAIMER exists > >- NOTICE looks good > >- LICENSE looks good (see notes below) > >- signature is valid > >- Apache license headers in source files (see notes below) > > > >NOTES: > > > >- In the LICENSE file, you don’t need to include the entire content of > the Mozilla Public License, the following text should suffice: > > > > This Source Code Form is subject to the terms of the Mozilla Public > > License, v. 2.0. If a copy of the MPL was not distributed with this > > file, You can obtain one at http://mozilla.org/MPL/2.0/. > > > >- Since the Elastic Search code is ASLv2 licensed, you don’t need to have > that entry in the LICENSE file > >- “slapd.seed” does not have an Apache license header, but I’m not > familiar with the file format and don’t know if it supports comments. > >- “.travis.yml” and the “.*” files under “metron-ui” are missing Apache > license headers > >- KEYS doesn’t need to be part of the source distribution, but that > doesn’t seem like a big deal > >- COPYING under ./bro-plugin-kafka is just a copy of the Apache license > and can probably be deleted. > >- The source archive is named > "apache-metron-0.1BETA-RC6-incubating.tar.gz” but expands to > "incubator-metron-Metron_0.1BETA_rc6” (probably not a big deal) > > > >I don’t think any of the above issues will/should block the release. > Incubator projects have some leeway in terms of releasing with minor > licensing issues. A lot of times, simply having a JIRA ticket to address > such issues in the next release will suffice and allow the release to go > forward. > > > >+1 (binding) > > > >-Taylor > > > >> On Mar 30, 2016, at 11:58 AM, James Sirota <[email protected]> > wrote: > >> > >> This is a call to vote on releasing Apache Metron 0.1BETA-RC6 > >> > >> Full list of changes in this release: > >> > >> > https://dist.apache.org/repos/dist/dev/incubator/metron/0.1BETA-RC6-incubating/CHANGES > >> > >> The tag/commit to be voted upon is Metron_0.1BETA_rc6: > >> > >> > https://git-wip-us.apache.org/repos/asf?p=incubator-metron.git;a=commit;h=8973c9b5889586e70213e526cd58e33165192db0 > >> > >> The source archive being voted upon can be found here: > >> > >> > https://dist.apache.org/repos/dist/dev/incubator/metron/0.1BETA-RC6-incubating/apache-metron-0.1BETA-RC6-incubating.tar.gz > >> > >> Other release files, signatures and digests can be found here: > >> > >> > https://dist.apache.org/repos/dist/dev/incubator/metron/0.1BETA-RC6-incubating/ > >> > >> The release artifacts are signed with the following key: > >> > >> > https://git-wip-us.apache.org/repos/asf?p=incubator-metron.git;a=blob_plain;f=KEYS;hb=dc59e37e402bd868aeac7ab42a0cc9c51ccae3c2 > >> > >> The Nexus staging repository for this release will be created after > this vote has been passed. > >> > >> > >> Please vote on releasing this package as Apache Metron 0.1BETA-RC6. > >> > >> When voting, please list the actions taken to verify the release. > >> Recommended build validation and verification instructions are posted > here: > >> https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds > >> > >> This vote will be open for at least 72 hours. > >> > >> [ ] +1 Release this package as Apache Metron 0.1BETA-RC6 > >> [ ] 0 No opinion > >> [ ] -1 Do not release this package because... > > >
