Github user dlyle65535 commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/68#discussion_r58472376
  
    --- Diff: deployment/roles/metron_streaming/defaults/main.yml ---
    @@ -34,3 +39,6 @@ storm_topologies:
         - "{{ metron_directory }}/config/topologies/yaf/remote.yaml"
         - "{{ metron_directory }}/config/topologies/pcap/remote.yaml"
         - "{{ metron_directory }}/config/topologies/enrichment/remote.yaml"
    +hdfs_retention_days: 30
    +hdfs_bro_purge_cronjob: "yarn jar {{ metron_directory }}/lib/{{ 
metron_dataloads_jar }} org.apache.metron.dataloads.bulk.HDFSDataPruner -f {{ 
hdfs_url }} -g '/apps/metron/enrichment/indexed/bro_doc/*enrichment-*' -s 
$(date -d '{{ hdfs_retention_days }} days ago' +%m/%d/%Y) -n 1 >> 
/var/log/bro-purge/cron-bro-purge.log 2>&1"
    --- End diff --
    
    I'd prefer not to shadow the command line options that the main class 
exposes. That seems overly complicated to me. If you want me to wrap the yarn 
shell script in shell script that is shorter, I can see the value in that, but 
running yarn jar foo.jar main.class args is kind of a regular thing, no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to