Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/58#discussion_r59919240
  
    --- Diff: deployment/playbooks/metron_install.yml ---
    @@ -75,7 +75,8 @@
         - { role: flume,  when: install_snort | default(True) == True }
         - { role: snort , when: install_snort | default(True) == True }
         - { role: yaf, when: install_yaf | default(True) == True }
    -    - { role: pcap_replay , when: pcap_replay | default(False)  == True }
    +    - { role: pcap_replay , when: (pcap_replay | default(False)) or 
(sensor_test_mode | default(False)) == True }
    +    - { role: sensor-test-mode, when: sensor_test_mode | default(False) == 
True }
    --- End diff --
    
    Although sensor-test-mode has pcap_replay as a dependency in 
`deployments/roles/sensor-test-mode/meta/main.yml`, so maybe I do not need need 
the extra logic in `deployment/playbooks/metron_install.yml`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to