GitHub user jjonez opened a pull request:
https://github.com/apache/incubator-metron/pull/113
Metron 136 logrotate pcapservice
I tested this by starting the full-dev-platform vagrant image. The
logrotate.d config file was created. I ran logrotate with the -f option (force)
to test the configuration and it worked properly.
The configuration is consistent with the other logrotate configs in metron,
but I have a couple of questions, which perhaps should be posted elsewhere.
These questions apply to most of the default Metron logrotate configurations:
#1 - Should the pcap logs be in their own directory like most other metron
logs instead of /var/log/metron_pcapservice.log?
#2 - Should we change to compress (gzip)?
#3 - Regarding all logrotate configs, should we change them to use dateext?
Currently it changes files like this:
/var/log/metron_pcapservice.log.1
/var/log/metron_pcapservice.log.2
Where, using dateext makes them:
/var/log/metron_pcapservice.log.20160507
/var/log/metron_pcapservice.log.20160508
The disadvantage to this is that even if you try to force the rotate (-f),
I don't think it will rotate because the date it would rotate to already
exists. With the number, if just adds a new number.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jjonez/incubator-metron
METRON-136_logrotate_pcapservice
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit ba6200857c02914ec1df3e06d6ba701b5bee5aaf
Author: James Jones <[email protected]>
Date: 2016-05-09T16:42:04Z
Added daily logrotate to pcap_service. I also verified that it created the
file and I tested the execution in the full-dev-platform image using the
logrotate -f option (force). It properly rotated to
/var/log/metron_pcapservice.log.1.
commit 41517ac1273f21a08965d039ef0e6a2cf51e7fb8
Author: James Jones <[email protected]>
Date: 2016-05-09T16:42:28Z
Added daily logrotate to pcap_service. I also verified that it created the
file and I tested the execution in the full-dev-platform image using the
logrotate -f option (force). It properly rotated to
/var/log/metron_pcapservice.log.1.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
