Github user merrimanr commented on the pull request:
https://github.com/apache/incubator-metron/pull/129#issuecomment-221297517
As this PR stands, instantiation and configuration of MessageFilter and
MessageParser classes are done differently in different places. Would it make
sense to create and configure them both the same way? I imagine this will
apply to MessageWriter too as it becomes more configurable. Functionally it
doesn't matter much so this is more of a style issue. Not critical and either
approach is fine but a common pattern would make the code easier to understand
I think.
Overall looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---