Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/142#discussion_r66814113
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/aggregator/Aggregators.java
---
@@ -18,18 +18,21 @@
package org.apache.metron.common.aggregator;
+import org.apache.metron.common.utils.ConversionUtils;
+
import java.util.List;
import java.util.Map;
import java.util.function.BinaryOperator;
import java.util.function.Predicate;
public enum Aggregators implements Aggregator {
- MAX( (numbers, config) -> accumulate(0d, (x,y) ->
Math.max(x.doubleValue(),y.doubleValue()), numbers))
- ,MIN( (numbers, config) -> accumulate(0d, (x,y) ->
Math.min(x.doubleValue(),y.doubleValue()), numbers))
- ,SUM( (numbers, config) -> accumulate(0d, (x,y) -> x.doubleValue() +
y.doubleValue(), numbers))
+ MAX( (numbers, config) -> accumulate(0d, (x,y) ->
Math.max(x.doubleValue(),y.doubleValue()), numbers, config))
+ ,MIN( (numbers, config) -> accumulate(0d, (x,y) ->
Math.min(x.doubleValue(),y.doubleValue()), numbers, config))
+ ,SUM( (numbers, config) -> accumulate(0d, (x,y) -> x.doubleValue() +
y.doubleValue(), numbers, config))
,MEAN( (numbers, config) -> scale(SUM.aggregate(numbers, config),
numbers, n -> true))
- ,POSITIVE_MEAN( (numbers, config) -> scale(SUM.aggregate(numbers,
config), numbers, n -> n.doubleValue() > 0))
+ ,POSITIVE_MEAN( (numbers, config) -> positiveMean(numbers, config))
;
+ public static String NEGATIVE_VALUES_TRUMP_CONF = "negativeValuesTrump";
--- End diff --
It is not intuitive to me what this means. NEGATIVE_VALUES_TRUMP_CONF?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
