Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/208#discussion_r75326025
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -247,19 +301,24 @@ public static void uploadConfigsToZookeeper(String
globalConfigPath, String pars
}
public static void visitConfigs(CuratorFramework client,
ConfigurationVisitor callback) throws Exception {
- visitConfigs(client, callback, ConfigurationType.GLOBAL);
- visitConfigs(client, callback, ConfigurationType.PARSER);
- visitConfigs(client, callback, ConfigurationType.ENRICHMENT);
+ visitConfigs(client, callback, GLOBAL);
--- End diff --
Not a big deal, but maybe we could make visitConfigs take a vararg of
ConfigurationType and then pass in `GLOBAL`, `PARSER`, `ENRICHMENT`, `PROFILER`
in as args
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
