Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/265#discussion_r79862290
  
    --- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/shell/StellarShell.java
 ---
    @@ -244,6 +304,55 @@ private void write(String out) {
       }
     
       private void writeLine(String out) {
    -    System.out.println(out);
    +    console.getShell().out().println(out);
    +  }
    +
    +  @Override
    +  public int execute(ConsoleOperation output) throws InterruptedException {
    +    String expression = output.getBuffer().trim();
    +    if(StringUtils.isNotBlank(expression)) {
    +      if(isMagic(expression)) {
    +        handleMagic( expression);
    +
    +      } else if(isDoc(expression)) {
    +        handleDoc(expression);
    +
    +      } else if (expression.equals("quit")) {
    +        try {
    --- End diff --
    
    Does this prevent the user from referring to a variable called `quit`?  If 
so, maybe `%quit`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to