Github user dlyle65535 commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/323#discussion_r84939411
  
    --- Diff: metron-deployment/roles/snort/tasks/producer.yml ---
    @@ -15,5 +15,18 @@
     #  limitations under the License.
     #
     ---
    -hdp_repo_def: 
"http://public-repo-1.hortonworks.com/HDP/centos6/2.x/updates/2.4.2.0/hdp.repo";
    -java_home: /usr/jdk64/jdk1.8.0_60
    +- name: Create Snort producer home directory
    +  file:
    +    path: "{{ snort_producer_home }}"
    +    state: directory
    +    mode: 0755
    +
    +- name: Install Snort producer start script
    +  template: src=start-snort-producer.sh dest={{ snort_producer_home 
}}/start-snort-producer.sh mode=0755
    +
    +- name: Install init.d service script
    +  template: src=snort-producer dest=/etc/init.d/snort-producer mode=0755
    +
    +- name: Register the service with systemd
    +  shell: systemctl enable snort-producer
    +  when: ansible_distribution == "CentOS" and 
ansible_distribution_major_version == "7"
    --- End diff --
    
    I don't think you need this. The way it is currently written, it will 
enable service start on boot for Centos 7 only. If you want to enable on 
bootup, you can use the Ansible service module with enabled set to yes. Ansible 
will (should) take care of figuring out which os you're running an do the right 
thing.
    Otherwise, you can just remove this block.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to