Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/334#discussion_r86029925
--- Diff:
metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java
---
@@ -82,19 +84,53 @@
public class GetProfile implements StellarFunction {
/**
- * A global property that defines the name of the HBase table storing
profile definitions.
+ * A global property that defines the name of the HBase table used to
store profile data.
*/
- public static final String PROFILER_HBASE_TABLE = "profiler.hbase.table";
+ public static final String PROFILER_HBASE_TABLE =
"profiler.client.hbase.table";
/**
* A global property that defines the name of the column family used to
store profile data.
*/
- public static final String PROFILER_COLUMN_FAMILY =
"profiler.column.family";
+ public static final String PROFILER_COLUMN_FAMILY =
"profiler.client.hbase.column.family";
/**
* A global property that defines the name of the HBaseTableProvider
implementation class.
*/
- public static final String PROFILER_HBASE_TABLE_PROVIDER =
"profiler.hbase.table.provider";
+ public static final String PROFILER_HBASE_TABLE_PROVIDER =
"hbase.provider.impl";
--- End diff --
This isn't an objection, just a question: I'm not yet real familiar with
the structure of the configuration tree in ZK. Is this "hbase.provider.impl"
parameter stored in a part of the tree where it clearly ONLY applies to
profiler? Otherwise I would prefer to leave it with a "profiler." prefix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
