I would like to understand what specific to your PR regressed the Storm 1.0
integration.  Maybe Casey or someone a little more familiar with what went
into troubleshooting that patch can help.


On November 1, 2016 at 21:57:57, Kyle Richardson ([email protected])
wrote:

Thanks, Otto! You're a genius.

I'm at a loss for why this broke the integration tests. For me, it seems to
have broke all of the integration tests which makes me think it broke some
piece of the underlying framework. The big change seems to have been with
the move to Storm 1.x but I can't say for sure it's related.

I had managed to get rid of all of the SLF4J multiple bindings prior to
rebasing so my guess is there was a change in some of the dependencies that
added these back in.

I've added the exclusion you highlighted as well as a couple of others to
get rid of the multiple bindings. I'm running through the unit and
integration tests now and, if successful, I'll push the fix to my PR and
see what Travis comes back with.

Thanks again for your help troubleshooting!

-Kyle

On Tue, Nov 1, 2016 at 4:52 PM, Otto Fowler <[email protected]>
wrote:

> Sorry, same test.
>
> I was able to resolve the issue by adding an exclusion for slf4j in the
> metron-parsers pom:
>
> <dependency>
> <groupId>org.apache.kafka</groupId>
> <artifactId>kafka_2.10</artifactId>
> <version>${global_kafka_version}</version>
> <exclusions>
> <exclusion>
> <artifactId>slf4j-log4j12</artifactId>
> <groupId>org.slf4j</groupId>
> </exclusion>
> <exclusion>
> <groupId>log4j</groupId>
> <artifactId>log4j</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
>
>
> I’m not sure why this would break with the asa parser though. Maybe
> someone else has an idea?
>
> On November 1, 2016 at 16:16:27, Otto Fowler ([email protected])
> wrote:
>
> Kyle:
>
> I can reproduce this problem ( but with a different test ) locally.
>
> -------------------------------------------------------
>
> T E S T S
>
> -------------------------------------------------------
>
> Running org.apache.metron.parsers.integration.AsaIntegrationTest
>
> SLF4J: Class path contains multiple SLF4J bindings.
>
> SLF4J: Found binding in
> [jar:file:/Users/ottofowler/.m2/repository/org/slf4j/slf4j-
> log4j12/1.7.21/slf4j-log4j12-1.7.21.jar!/org/slf4j/impl/
> StaticLoggerBinder.class]
>
> SLF4J: Found binding in
> [jar:file:/Users/ottofowler/.m2/repository/org/slf4j/slf4j-
> simple/1.7.7/slf4j-simple-1.7.7.jar!/org/slf4j/impl/
> StaticLoggerBinder.class]
>
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
>
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
>
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.509 sec
> <<< FAILURE! - in
org.apache.metron.parsers.integration.AsaIntegrationTest
>
> test(org.apache.metron.parsers.integration.AsaIntegrationTest) Time
> elapsed: 3.506 sec <<< ERROR!
>
> java.lang.NoClassDefFoundError: org/slf4j/event/LoggingEvent
>
> I *did* pull master over your pr.
>
> Can you merge/pull master and update your local branch and reproduce?
>
>
>
> On November 1, 2016 at 15:33:55, Otto Fowler ([email protected])
> wrote:
>
> " T E S T S
>
> -------------------------------------------------------
> Running org.apache.metron.parsers.integration.YafIntegrationTest
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-
> log4j12/1.7.21/slf4j-log4j12-1.7.21.jar!/org/slf4j/impl/
> StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-
> simple/1.7.7/slf4j-simple-1.7.7.jar!/org/slf4j/impl/
> StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 8.64
> sec <<< FAILURE! - in
> org.apache.metron.parsers.integration.YafIntegrationTest
> test(org.apache.metron.parsers.integration.YafIntegrationTest) Time
> elapsed: 8.637 sec <<< ERROR!
> java.lang.NoClassDefFoundError: org/slf4j/event/LoggingEvent”
>
>
> This error, then a address already in use errors…. then no output -
> travis kills it.
>
> Maybe this error causes an ungraceful shutdown, which effects the next
> test?
>
>
> I’ll grab your pr clean and try to run mvn test && mvn
> integration-test on it and see here. I assume that this builds
> locally for you and the test and integration-tests run?
>
>
>
>
> On November 1, 2016 at 13:17:47, kylerichardson ([email protected])
> wrote:
>
> Github user kylerichardson commented on the issue:
>
> https://github.com/apache/incubator-metron/pull/276
>
> Ok, need some helping figuring out why the CI build keeps failing...
>
> I get several of these at the end of the log:
> ```
> Running org.apache.metron.parsers.integration.JSONMapIntegrationTest
> 2016-11-01 15:54:52 FATAL KafkaServer:116 - [Kafka Server 0], Fatal error
> during KafkaServer startup. Prepare to shutdown
> kafka.common.KafkaException: Socket server failed to bind to
> localhost:6667: Address already in use.
> ```
>
> and prior to that I see:
> ```
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 8.64 sec
> <<< FAILURE! - in
org.apache.metron.parsers.integration.YafIntegrationTest
> test(org.apache.metron.parsers.integration.YafIntegrationTest) Time
> elapsed: 8.637 sec <<< ERROR!
> java.lang.NoClassDefFoundError: org/slf4j/event/LoggingEvent
> ```
>
> This occurred for both of the CI builds since I rebased to the latest
> master. Any ideas?
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have
your
> reply appear on GitHub as well. If your project does not have this
feature
> enabled and wishes so, or if the feature is enabled but not working,
please
> contact infrastructure at [email protected] or file a JIRA ticket
> with INFRA.
> ---
>

Reply via email to