GitHub user ottobackwards opened a pull request:
https://github.com/apache/incubator-metron/pull/344
METRON-538 (DO NOT MERGE) Ensure proper shutdown, exceptions of integration
test components
This is an effort to eliminate spam errors from our testing and hopefully
improve our testing at the same time.
This PR will track the commits for this effort, and allow for timely
comment and review.
So far the things we are looking for or seeing are
- problems with shutdown dependencies with the testing components like yarn
and zk
- problems were we cannot completely mock out components. Even if the
tests pass, we are spammed with errors because of the attempts to connect to
components that are part of the test because they are not needed.
My goal is to keep this PR mergable with every commit as I go.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/incubator-metron METRON-538
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/344.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #344
----
commit 6d230bada58bf297365b289affc375a48ce1da84
Author: Otto Fowler <[email protected]>
Date: 2016-11-03T17:44:32Z
In Maas Integration, be sure to shutdown zookeeper AFTER yarn, to avoid
extra errors when shutting down yarn
commit fb79f16b71f781ba02c7c7b9ec33d17444bfe320
Author: Otto Fowler <[email protected]>
Date: 2016-11-03T19:46:29Z
Make HBaseBolt testable by allowing building with a provided table provider
as opposed to building from string, this allows mocking. This eliminates log
spam of errors when the runtime class still attempts and fails to connect to
zookeeper, which is not running or needed for this test. I did not change the
function for withTableProvider() because I do not know all the consequences of
changing the flux configurations
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
