I'm fine with it. It's more consistent with your change. On Fri, Nov 18, 2016 at 19:42 Matt Foley <[email protected]> wrote:
> Hi Casey, and dev-list, > > Directing this to Casey because you are the only contributor to the > affected file: > > > > > metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/writer/ParserWriterConfiguration.java > > uses > > public static final String BATCH_CONF = "batchSize"; > > > > For METRON-322 / METRON-516, I need to add “batchTimeout” to go along with > “batchSize”. I plan to set > > public static final String BATCH_TIMEOUT_CONF = " batchTimeout "; > > > > I would like to change BATCH_CONF to BATCH_SIZE_CONF, here and in > ParserBoltTest.java and WriterBoltTest.java. > > These are the only places the symbol is used in Metron. > > > > The risk of course is if anyone writing 3rd party code has used > “ParserWriterConfiguration.BATCH_CONF”. > > It seems a small risk to me, so I would prefer the clearer label. But if > you or others think it best to leave it as “BATCH_CONF” instead of > “BATCH_SIZE_CONF”, just say so and I will. > > > > Thanks, > > --Matt > > > > >
