Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/366#discussion_r89027465
  
    --- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/shell/StellarExecutor.java
 ---
    @@ -143,11 +153,13 @@ public StellarExecutor(Console console) throws 
Exception {
     
       public StellarExecutor(String zookeeperUrl, Console console) throws 
Exception {
         this.variables = new HashMap<>();
    -    this.functionResolver = new StellarFunctions().FUNCTION_RESOLVER();
         this.client = createClient(zookeeperUrl);
         this.context = createContext();
    +    StellarFunctions.initialize(this.context);
    +    this.functionResolver = StellarFunctions.FUNCTION_RESOLVER();
    --- End diff --
    
    I'd prefer everyone's REPL to not include the same includes and excludes as 
the global config, which may be used on the running cluster.  Can we, instead, 
have the REPL take a JSON config that can set the stellar configs?  I'm ok if 
we set the default config to the one in global config, but the user should be 
able to override.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to