Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/301
I totally forgot about this. Looking over this again, I am a little
ambivalent about this PR.
I did as an experiment. I thought it would be cool, if parameter handling
could be taken care of auto-magically. I wanted to just specify the parameters
that I need via the annotation and have some shared logic perform parameter
handling and validation, along with enhancing the docs. Seems more DRY-ish and
all that.
As this stands, I don't think it is very useful. Different functions want
to handle required params in different ways. Sometimes an exception is thrown,
sometime a value is returned like NaN, etc. This doesn't give you any
flexibility in how to respond to missing params. There are probably a few
other things that need to be covered before this is close to being useful.
I would be interested in opinions on this though. Maybe with input from
others this could become useful. But right now, I am a -1 on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
