GitHub user justinleet opened a pull request:
https://github.com/apache/incubator-metron/pull/376
METRON-593: Enable an automated static analysis tool in the build
Setup everything to use [Error Prone](http://errorprone.info/) with errors
fixed and warnings on. This increases build output, but it still seems fairly
manageable.
We had a lot of the poms redefining the maven-compiler-plugin entirely, or
just adding ```<compilerArgument>-Xlint:unchecked</compilerArgument>```, so I
made them all just inherit from the root pom with ```-Xlint:unchecked``` on.
It seems reasonable to leave it on everywhere, and simplifies the POMs, but if
anyone has a strong objection, it's easy to change it to whatever we want.
Assuming we're good with this approach to our static analysis, we'd create
a follow on ticket (or tickets?) to address them. After addressing them, we
probably should swing back around and upgrade some or all of our warnings to
errors, so we don't have to deal with them cropping up again.
Tests were run successfully and quick-dev was spun up to with some data
pushed through.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinleet/incubator-metron errorprone
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/376.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #376
----
commit 0da475301dc4dba9a3f316c7e0b2b07d935e7e97
Author: justinjleet <[email protected]>
Date: 2016-11-09T16:31:04Z
errorprone on common
commit 426844d5610a4e9a04fac86d794cab9ece27d696
Author: justinjleet <[email protected]>
Date: 2016-11-29T15:29:38Z
Extending to all modules, errors fixed
commit 3da4ca496cad0986163c1406cdb6c522c2d9439a
Author: justinjleet <[email protected]>
Date: 2016-11-29T17:06:08Z
Inheriting compiler from root pom, rather than redefining everywhere
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
