Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/396#discussion_r92498864
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java
---
@@ -76,12 +77,15 @@ public void prepare(Map stormConf, TopologyContext
context, OutputCollector coll
if(getSensorParserConfig() == null) {
filter = new GenericMessageFilter();
}
- else if(filter == null) {
+ if(filter == null) {
getSensorParserConfig().getParserConfig().putIfAbsent("stellarContext",
stellarContext);
- filter = Filters.get(getSensorParserConfig().getFilterClassName()
- , getSensorParserConfig().getParserConfig()
- );
+
if(!StringUtils.isEmpty(getSensorParserConfig().getFilterClassName())) {
--- End diff --
Well, it was confusing to see. Why does GenericMessageFilter exist at all
then? At the very least I would think to put a comment in to explain why you
are doing it that way for maintenance purposes if you leave it like that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
