Github user cestella commented on the issue:

    https://github.com/apache/incubator-metron/pull/404
  
    One further thought: regarding the validation, I just want to point out 
that I'd be ok for validation to not *execute* the statement, but only validate 
syntactic correctness and function existence.  It just means that we will need 
to augment `StellarProcessorUtils` to execute with a map that returns null for 
its variables to ensure our tests continue to cover the same way.
    
    I do think we should retain the functionality that comparisons involving 
nulls operate in a sensible way.  I think any comparison involving `null` 
should return `false` sort of like how doubles function with `NaN`.  Also, the 
decisions made here should be included in the stellar section of the README.md 
as part of this PR.
    
    I'm coming around about `==` operating strictly for doubles.  I could see 
how that would violate the principle of least surprise for people coming from 
other languages.  I guess I never had much use for `==` with `double`s and 
thought I could automatically save people some obvious errors, but I think the 
current approach is problematic and probably should be scrapped for what this 
PR does.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to