Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/401#discussion_r95371725
  
    --- Diff: 
metron-analytics/metron-statistics/src/test/java/org/apache/metron/statistics/StellarStatisticsFunctionsTest.java
 ---
    @@ -356,6 +357,49 @@ public void testSkewness() throws Exception {
         assertEquals(stats.getSkewness(), (Double) actual, 0.1);
       }
     
    +  @Test
    +  public void testStatsBin() throws Exception {
    --- End diff --
    
    Given that it's not entirely obvious what this is doing and why it is a 
valid test, do you think it merits a comment with the above in the test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to