Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/414#discussion_r95620903
--- Diff:
metron-analytics/metron-profiler-client/src/test/java/org/apache/metron/profiler/client/GetProfileTest.java
---
@@ -116,6 +119,33 @@ public void setup() {
.build());
}
+ private Context setup2() {
--- End diff --
This is a test to demonstrate that the "current" configuration can be set
differently than the "historical" configuration, and then both the positive and
negative test cases work right. `setup2()` is modeled exactly on `setup()`,
except that it uses `periodDuration2`, `periodUnits2` and `saltDivisor2`,
instead of `periodDuration`, `periodUnits` and `saltDivisor` respectively.
However, you're right that this is a little opaque, because setup() is
called in the @Before clause, while setup2() is called in the midst of the test
routine. Let me add some comments that clarify this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
