Github user JonZeolla commented on the issue:
https://github.com/apache/incubator-metron/pull/455
Sounds good to me. I typically use declare for all variables just to be
explicit and obvious with my intent, and use $() as a standard for readability
and easy nesting as opposed to \`\`. That said, as you mentioned, they are
definitely equivalent to what you have across the board.
I did a quick review on my phone, but there are enough changes it probably
merits a run up and validation on a screen larger than 5". That said, I would
consider adding something like:
```
If [ -e $fullpath/site.xml.bak ]; then
mv $fullpath/site.xml.bak $fullpath/site.xml
fi
```
To the quit function to reinstate the prior site.xml (replacing `$fullpath`
appropriately). I'll try to spin this up today if I can because I'm gone all
next week without access to the real world (i.e. Internet).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
