Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/468#discussion_r103549252
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/resolver/ClasspathFunctionResolver.java
---
@@ -65,24 +72,48 @@
*
*/
public class ClasspathFunctionResolver extends BaseFunctionResolver {
-
- /**
- * The key for a global property that defines one or more regular
expressions
- * that specify what should be included when searching for Stellar
functions.
- */
- public static final String STELLAR_SEARCH_INCLUDES_KEY =
"stellar.function.resolver.includes";
-
- /**
+ public enum Config {
+ STELLAR_VFS_PATHS("stellar.function.paths", ""),
+ /**
+ * The key for a global property that defines one or more regular
expressions
+ * that specify what should be included when searching for Stellar
functions.
+ */
+ STELLAR_SEARCH_INCLUDES_KEY("stellar.function.resolver.includes", ""),
--- End diff --
Do we still need this with the index-based approach? We had this here
before to minimize how many packages we had to search because it was so time
consuming. What purpose does it serve now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
