GitHub user mattf-horton opened a pull request:
https://github.com/apache/incubator-metron/pull/532
METRON-634 Mpack bug fixes and improvements, not impacting Ambari database
These changes fix the following significant bugs:
*
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-sysconfig.xml
* Fixes necessary for Centos7: PID_DIR and JAVA_HOME added for systemd
launch
*
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/package/scripts/elastic.py
* fix permissions on scripts directory
* fix elastic_group usage (missed one in previous patch)
* remove incorrect and spurious use of undefined format() method
*
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/package/scripts/elastic_master.py
*
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/package/scripts/elastic_slave.py
* remove incorrect and spurious uses of undefined format() method
*
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-site.xml
* Fix default value of "network_host" (ie network binding names), which
breaks in some envs
Also the following minor issue corrections and description/comment
improvements are made:
*
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/package/scripts/params.py
* fix incorrect override of pid_dir and pid_file, which are correctly
defined in elastic-env.xml and ELASTICSEARCH status_params.py
*
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/metainfo.xml
*
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/quicklinks/quicklinks.json
* Add quicklinks to Elastic page in Ambari, for ES health status page and
indexes list page; very useful for debugging the install.
*
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-site.xml
*
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml
* Non-substantive changes to descriptions or comments, meant to improve
usability.
* Also an ordering change and add newline at end of file.
These fixes are only the first half of METRON-634. The second half cause
changes to the Ambari database, and therefore require an update script. These
will be done in a separate PR, when I have time to do it. The changes here are
stand-alone improvements.
## Contributor Comments
These issues were worked out over several weeks of working with Mpack on
Centos7, and documented in METRON-634. @dlyle65535 adopted some into the
Ansible work, but most remain to be done.
They have been tested manually, and through a full run of integration test.
If you are running Centos7, you will only notice the bug fixes as smoother
startup of Elasticsearch.
The description improvements make it easier for manual users of Mpack
Ambari install.
## Pull Request Checklist
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- The issues were not noticed by most users anyway. Recommend that
developers familiar with the guts of Mpack review the changes by inspection.
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [NA] Have you written or updated unit tests and or integration tests to
verify your changes?
- [NA] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [NA] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattf-horton/incubator-metron METRON-634
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/532.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #532
----
commit 3a066f829b71729290bcc5d38cf6420040a6dc9a
Author: mattf-horton <[email protected]>
Date: 2017-04-13T21:18:23Z
METRON-634 Mpack bug fixes and improvements, not impacting Ambari database
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
