Looks great indeed :)

Btw. thank you very much for your help before.

Are the changes already commited to the trunk?

Best Regards
Michael


Niklas Therning schrieb:
Trustin Lee wrote:
On 11/22/06, Niklas Therning <[EMAIL PROTECTED]> wrote:
...
BTW, the above would be a lot cleaner if we had setSessionConfig() on
SocketAcceptor, DatagramAcceptor, etc. What do people think about adding
such setters?

I think it's a great idea.  :D

Trustin
I've made the necessary changes to socket and datagrams transports.
Nothing has been changed for vmpipe transport since there is no
VmPipeSessionConfig. With this change the Spring XML config will be simpler:

<bean id="ioAcceptor"
class="org.apache.mina.transport.socket.nio.SocketAcceptor"
init-method="bind" destroy-method="unbind">
  <property name="localAddress" value=":1234"/>
  <property name="handler" ref="TcpServerSessionHandler"/>
  <property name="sessionConfig">
    <bean
class="org.apache.mina.transport.socket.nio.SocketSessionConfigImpl">
      <property name="reuseAddress" value="false"/>
      <property name="tcpNoDelay" value="true"/>
      <property name="sendBufferSize" value="1024"/>
      <property name="receiveBufferSize" value="1024"/>
      <property name="soLinger" value="10"/>
      <property name="oobInline" value="false"/>
      <property name="keepAlive" value="true"/>
    </bean>
  </property>
</bean>


Reply via email to