Trustin, are you proposing to change the workerTimeout from default 60 seconds + configurable to 5 seconds hard-coded ?
Not that I have an objection right now, just want to make sure that I understand your proposal. On 11/24/06, Trustin Lee <[EMAIL PROTECTED]> wrote:
Hi, The workerTimeout property of SocketConnector prevents its worker thread from dying too soon that a following connection attempt takes too long time because of new instantiation of Selector and Thread. The default value is 1 minute, and can be changed by calling setWorkerTimeout() method. My question here is, does it really need to be configurable? Because we are having the same issue with SocketIoProcessor, we will also have to add the property to SocketAcceptor if it should be configurable. We can simply add it, but I want to know if it is really need to be configurable. Say we just hard-coded the workerTimeout to 5 seconds. The worst case is that connection attempts take place every 5 seconds, but it's *big* 5 seconds which make the instantiation overhead (for Selector and Thread) negligible. Any feedbacks are welcome, and I will get rid of workerTimeout property if there's no objection within 3 days. Trustin -- what we call human nature is actually human habit -- http://gleamynode.net/ -- PGP key fingerprints: * E167 E6AF E73A CBCE EE41 4A29 544D DE48 FE95 4E7E * B693 628E 6047 4F8F CFA4 455E 1C62 A7DC 0255 ECA6
