[jira] Commented: (DIRMINA-364) Include Runtime.getRuntime().availableProcessors() into the constructors of SocketAcceptor

[Mark Webb (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DIRMINA-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496189
 ] 

Mark Webb commented on DIRMINA-364:
-----------------------------------

I have added the following constructor:

public SocketAcceptor(Executor executor) 
{
        this(Runtime.getRuntime().availableProcessors(), executor);
} 


Additionally, I have updated the default constructor to the following:

public SocketAcceptor()
{
    this( new NewThreadExecutor() );
}

> Include Runtime.getRuntime().availableProcessors() into the constructors of 
> SocketAcceptor
> ------------------------------------------------------------------------------------------
>
>                 Key: DIRMINA-364
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-364
>             Project: MINA
>          Issue Type: Improvement
>          Components: Transport
>    Affects Versions: 2.0.0-M1
>            Reporter: im-james
>            Priority: Trivial
>             Fix For: 2.0.0-M1
>
>
> I propose to change the default constructor of SocketAcceptor for this :
> public SocketAcceptor() {
>         this(Runtime.getRuntime().availableProcessors(), new 
> NewThreadExecutor());
> }
> And to add a new constructor:
> public SocketAcceptor(Executor executor) {
>         this(Runtime.getRuntime().availableProcessors(), executor);
> }
> The objective is to maximize the performance of MINA in the usual cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.